Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[documentation]: update contributing doc #1282

Merged
merged 1 commit into from
Nov 29, 2024

Conversation

loosla
Copy link
Contributor

@loosla loosla commented Nov 29, 2024

This PR updates the contributing documentation to improve the development process for both external contributors and internal DigitalOcean teams.

Changes:

  • Added a detailed section on how to test code changes locally.
  • Reorganized content with subsections for better readability.
  • Adjusted the order of acceptance test commands, moving the full suite section to the bottom to reduce the risk of accidentally running all tests.
  • Highlighted that acceptance tests use real resources, emphasizing the potential costs and impact.

@loosla loosla requested a review from a team November 29, 2024 21:13
Copy link
Member

@bentranter bentranter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Excellent change

@loosla loosla merged commit b96ae91 into main Nov 29, 2024
3 checks passed
@loosla loosla deleted the alushnikova/update-contributing branch November 29, 2024 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants